** Description changed: BugLink: https://bugs.launchpad.net/bugs/2142613 SRU Justification: [ Impact ] The net selftest helper wait_local_port_listen() is carried in the standalone tools/testing/selftests/net/net_helper.sh file in Noble. Upstream has moved this helper into the common tools/testing/selftests/net/lib.sh file and updated the affected tests to source lib.sh directly. Without this backport, affected net selftests can fail with "wait_local_port_listen: command not found" when tests are aligned with the newer upstream helper layout. [ Fix ] Backport upstream commit: - d9d836bfa5e6 ("selftests: net: move wait_local_port_listen to lib.sh") The backport moves wait_local_port_listen() into lib.sh, updates the Noble tests that used net_helper.sh to source lib.sh, removes net_helper.sh from TEST_FILES, and deletes the obsolete net_helper.sh file. [ Test Plan ] Validated in an Ubuntu Noble LXD VM (VM24): 1. Built the required net selftest helper binaries: - - udpgso_bench_tx - - udpgso_bench_rx - - xdp_dummy.o - - nat6to4.o + - udpgso_bench_tx + - udpgso_bench_rx + - xdp_dummy.o + - nat6to4.o 2. Ran affected helper users: - - ./udpgro.sh - - ./udpgro_bench.sh - - ./udpgro_frglist.sh - - ./pmtu.sh pmtu_ipv4_br_vxlan4_exception - - ./ipv6_route_update_soft_lockup.sh + - ./udpgro.sh + - ./udpgro_bench.sh + - ./udpgro_frglist.sh + - ./pmtu.sh pmtu_ipv4_br_vxlan4_exception + - ./ipv6_route_update_soft_lockup.sh 3. Verified the tests completed successfully and exercised - wait_local_port_listen() from lib.sh. + wait_local_port_listen() from lib.sh. [ Where problems could occur ] The change is limited to networking selftest scripts under tools/testing/selftests/net. It does not change kernel runtime code. Possible regressions would be limited to selftest execution if a script still expects net_helper.sh. Noble's existing net_helper.sh users are updated in this patch. [ Other Info ] The upstream commit also touched newer selftests that do not exist in Noble (for example, tools/testing/selftests/drivers/net/ and busy_poll_test.sh). Those unrelated selftest additions were not backported. [ Changes in v3 ] - Use the short Launchpad BugLink format: - https://bugs.launchpad.net/bugs/2142613. + https://bugs.launchpad.net/bugs/2142613. [ Changes in v2 ] - Update BugLink to https://bugs.launchpad.net/ubuntu-kernel- tests/+bug/2142613. + + ==== Original Bug Description ==== + On noble kernels, we brought in d15b3e4107b4ef52fadf0ad8d7d4ee35dd3f5ecf "selftests: net: replace sleeps in fcnal-test with waits" in noble stable patchset 2026-01-30 ( https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2139460 ). + + However, this change seems to depend on + d9d836bfa5e6e255c411733b4b1ce7a1f8346c54 "selftests: net: move + wait_local_port_listen to lib.sh", which has not been backported to + 6.6.y or 6.12.y. We'll need to add this patch as a SAUCE patch and/or + submit it upstream. + + The lack of "selftests: net: move wait_local_port_listen to lib.sh" + causes net:fcnal-test.sh to fail because it can't find + wait_local_port_listen. + + Here's an example log from noble:linux, but this type of error happens many times in fcnal-test.sh + 27558 03:23:24 DEBUG| [stdout] # tcp_l3mdev_accept disabled + 27559 03:23:24 DEBUG| [stdout] # + 27560 03:23:24 DEBUG| [stdout] # SYSCTL: net.ipv4.tcp_l3mdev_accept=0 + 27561 03:23:24 DEBUG| [stdout] # + 27562 03:23:24 DEBUG| [stdout] # ./fcnal-test.sh: line 1184: wait_local_port_listen: command not found + 27563 03:23:24 DEBUG| [stdout] # TEST: Global server - ns-A IP [ OK ] + 27564 03:23:24 DEBUG| [stdout] # ./fcnal-test.sh: line 1184: wait_local_port_listen: command not found + 27565 03:23:24 DEBUG| [stdout] # TEST: Global server - ns-A loopback IP [ OK ] + 27566 03:23:24 DEBUG| [stdout] # ./fcnal-test.sh: line 1192: wait_local_port_listen: command not found + 27567 03:23:24 DEBUG| [stdout] # TEST: Device server - ns-A IP [ OK ] + 27568 03:23:24 DEBUG| [stdout] # TEST: No server - ns-A IP [ OK ] + 27569 03:23:25 DEBUG| [stdout] # TEST: No server - ns-A loopback IP [ OK ] + 27570 03:23:25 DEBUG| [stdout] # ./fcnal-test.sh: line 1212: wait_local_port_listen: command not found + 27571 03:23:25 DEBUG| [stdout] # TEST: Client - ns-B IP [ OK ] + 27572 03:23:25 DEBUG| [stdout] # ./fcnal-test.sh: line 1218: wait_local_port_listen: command not found
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2142613 Title: net:fcnal-test.sh fails because it can't find wait_local_port_listen on noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2142613/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
