Launchpad has imported 4 comments from the remote bug at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66378.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://documentation.ubuntu.com/launchpad/user/reference/bugs/multi-project-bugs/about-multi-project-bugs/#bugs-in-external-trackers. ------------------------------------------------------------------------ On 2015-06-02T11:48:34+00:00 Michael Vogt wrote: Created attachment 35676 Patch that make syscall.Sendfile() use offset. The implementation in libgo/go/syscall/libcall_linux.go does not use the "offset" argument. Instead it uses soff and poff which is never initialized with the offset provided by the user (so always zero). This means that sendfile will not be correct for any offset != 0. Attached is a patch that fixes this issue, I verified the fix against our failing snappy testsuite that has a test for sendfile with alternative offsets. Reply at: https://bugs.launchpad.net/snappy/+bug/1460530/comments/9 ------------------------------------------------------------------------ On 2015-11-21T04:44:23+00:00 I-ian-1 wrote: Author: ian Date: Sat Nov 21 04:43:50 2015 New Revision: 230699 URL: https://gcc.gnu.org/viewcvs?rev=230699&root=gcc&view=rev Log: PR go/66378 syscall: Fix initial offset value in syscall.Sendfile. Bug reported in https://gcc.gnu.org/PR66378. Reviewed-on: https://go-review.googlesource.com/17159 Modified: trunk/gcc/go/gofrontend/MERGE trunk/libgo/go/syscall/libcall_bsd.go trunk/libgo/go/syscall/libcall_linux.go Reply at: https://bugs.launchpad.net/snappy/+bug/1460530/comments/11 ------------------------------------------------------------------------ On 2015-11-21T04:44:39+00:00 I-ian-1 wrote: Author: ian Date: Sat Nov 21 04:44:07 2015 New Revision: 230700 URL: https://gcc.gnu.org/viewcvs?rev=230700&root=gcc&view=rev Log: PR go/66378 syscall: Fix initial offset value in syscall.Sendfile. Bug reported in https://gcc.gnu.org/PR66378. Reviewed-on: https://go-review.googlesource.com/17159 Modified: branches/gcc-5-branch/libgo/go/syscall/libcall_linux.go Reply at: https://bugs.launchpad.net/snappy/+bug/1460530/comments/12 ------------------------------------------------------------------------ On 2015-11-21T04:45:01+00:00 Ian Lance Taylor wrote: Thanks for reporting the bug. It should be fixed now on mainline and GCC 5 branch. Reply at: https://bugs.launchpad.net/snappy/+bug/1460530/comments/13 ** Changed in: gcc Status: Unknown => Fix Released ** Changed in: gcc Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1460530 Title: ubuntu-snappy fails to build on *ARM*64 (fails during the tests) To manage notifications about this bug go to: https://bugs.launchpad.net/gcc/+bug/1460530/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
