I'm reviewing this following the
[documentation](https://ubuntu.com/project/docs/contributors/advanced/review-
a-merge-proposal/#review-checklist-template)
* Changelog:
- [+] Changelog entry has correct version and targeted codename
- [+] Correct formatting of changelog items
- [+] Bug references correct
- [N] Old content and logical tag match as expected (Package Merge)
* Release notes and Documentation
- [+] Added, updated, or enqueued relevant documentation.
- [+] Added, updated, or enqueued relevant release notes.
* Git/maintenance:
- [+] Commits are properly split (more important on -dev than on SRUs)
* Build/Test:
- [+] Build is OK
- [+] This is an SRU, the validation instructions are ok
- [+] Testcases added or adapted (N/A if not strictly required or already
present)
- [N] autopkgtest against the PPA package passes (if possible, evidence was
provided already)
- [+] Based on PPA builds and the build-log, no new component mismatch
expected
- [+] Verified PPA package installs/uninstalls
- [+] Verified PPA source package matches Merge Proposal source package
- [+] Verified function manually
The nitpick I have is that your changelog says "Retarget to Resolute".
I'd have prefered "Backport". But nevermind.
Additionally, I downloaded the source that is in stonking and compared
them to your branch with `diff -rqN`. As you warned me, a .mypy folder
was wrongly included in the Stonking upload. The changelog is the only
other difference so, LGTM.
$ dput ubuntu ../ubuntu-cuda-packaging-tools_1.0.4ubuntu~26.04.1_source.changes
Uploading ubuntu-cuda-packaging-tools using ftp to ubuntu (host:
upload.ubuntu.com; directory: /ubuntu)
running supported-distribution: check whether the target distribution is
currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known':
['release', 'proposed', 'updates', 'backports', 'security']}
running required-fields: check whether a field is present and non-empty in the
changes file
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running gpg: check GnuPG signatures before the upload
Uploading ubuntu-cuda-packaging-tools_1.0.4ubuntu~26.04.1.dsc
Uploading ubuntu-cuda-packaging-tools_1.0.4ubuntu~26.04.1.tar.xz
Uploading ubuntu-cuda-packaging-tools_1.0.4ubuntu~26.04.1_source.buildinfo
Uploading ubuntu-cuda-packaging-tools_1.0.4ubuntu~26.04.1_source.changes
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2164908
Title:
SRU: Update to upstream 1.0.4
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-cuda-packaging-tools/+bug/2164908/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
