I rechecked the gnome-46 implementations, and I don't think I should
claim that the lifetime issue is specific to FileChooser.

FileChooser is the path I originally investigated because I could
reproduce and quantify the retained memory there. In that path there are
two lifetime issues, first, the fake parent is not destroyed, and the
chooser is stored using g_object_ref_sink() while the close path
destroys the window without subsequently releasing that owned reference.

The fake-parent pattern is shared by other portals. Looking at them more
closely, the cleanup is not identical in every case. For example, Access
destroys and unreferences its actual dialog correctly, but its fake
parent still appears not to be destroyed. Account, Screenshot and
Wallpaper have patterns closer to FileChooser.

So at this point the measurements establish FileChooser as affected, but
they don't establish that it is the only affected portal. I think the
other fake-parent users should be tested individually rather than
assuming they are unaffected.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2166815

Title:
  [Noble] FileChooser portal retains GTK toplevel windows after each
  request

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal-gnome/+bug/2166815/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to