** Description changed:

+ [Impact]
+ 
+ The rabbitmq port-taken check added for LP: #2148342 is currently
+ overcomplicated, including an unneccesary systemd check if branch that
+ could be reduced to service rabbitmq-server status.
+ 
+ The simplification of this check should be added to resolute to unblock
+ noble and jammy SRUs
+ (https://bugs.launchpad.net/ubuntu/+source/rabbitmq-
+ server/+bug/2148342/comments/2)
+ 
+ [Test Plan]
+ 
+ Tests should confirm that the port taken check matches its previous
+ behavior. This includes:
+ 
+ - Installing garagemq followed by the new rabbitmq-server, confirming
+ 
+ WARNING: port 5672 is already in use by another application.
+ RabbitMQ server will not be started automatically.\
+ 
+ is displayed and the install succeeds.
+ 
+ - Installing rabbitmq-server, confirming the warning does not show up
+ - Upgrading rabbitmq-server, confirming the warning does not show up
+ 
+ Tests should be run on both a systemd-full and systemd-less container.
+ 
+ [Where problems could occur]
+ 
+ Problems with this update would most likely occur upon install of
+ rabbitmq-server on systems with systemd included, as the postinst check
+ is changed from "systemctl is-active --quiet rabbitmq-server.service" to
+ "service rabbitmq-server status >/dev/null"
+ 
+ [Other Info]
+  
+ The simplification was added to stonking in 4.3.2-4ubuntu3.
+ 
+ [Original Description]
+ 
  The active rabbitmq server check in rabbitmq-server.postinst is
  currently:
  
  if ss -ltn | grep -q ':5672 '; then
      if [ ""$(ps --no-headers -o comm 1) = "systemd" ] ; then
          if ! systemctl is-active --quiet rabbitmq-server.service; then
              echo "WARNING: port 5672 is already in use by another 
application."
              echo "RabbitMQ server will not be started automatically."
          fi
      else
          if ! service rabbitmq-server status >/dev/null 2>&1; then
              echo "WARNING: port 5672 is already in use by another 
application."
              echo "RabbitMQ server will not be started automatically."
          fi
      fi
  fi
  
  This is overly complicated and should be reduced to
  
  if ss -ltn | grep -q ':5672 ' && ! service rabbitmq-server status >/dev/null 
2>&1; then
      echo "WARNING: port 5672 is already in use by another application."
      echo "RabbitMQ server will not be started automatically."
  fi
  
  This will allow the check to be SRUed fully to supported releases
  (https://bugs.launchpad.net/ubuntu/+source/rabbitmq-
  server/+bug/2148342/comments/2)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2168867

Title:
  Simplify postinst check for active rabbitmq service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/2168867/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to