Resolute patch
Building against Kernel 7.0.0-39
=============
root@ubuntu-resolute:~# apt install
./doca-ofed-26.01-dkms_26.01.1.0.0.0.609.1-0ubuntu2.3_all.deb
Note, selecting 'doca-ofed-26.01-dkms' instead of
'./doca-ofed-26.01-dkms_26.01.1.0.0.0.609.1-0ubuntu2.3_all.deb'
Installing:
doca-ofed-26.01-dkms
Summary:
Upgrading: 0, Installing: 1, Removing: 0, Not Upgrading: 40
Download size: 0 B / 3136 kB
Space needed: 22.8 MB / 3557 MB available
Get:1 /root/doca-ofed-26.01-dkms_26.01.1.0.0.0.609.1-0ubuntu2.3_all.deb
doca-ofed-26.01-dkms all 26.01.1.0.0.0.609.1-0ubuntu2.3 [3136 kB]
Selecting previously unselected package doca-ofed-26.01-dkms.
(Reading database ... 157009 files and directories currently installed.)
Preparing to unpack
.../doca-ofed-26.01-dkms_26.01.1.0.0.0.609.1-0ubuntu2.3_all.deb ...
Unpacking doca-ofed-26.01-dkms (26.01.1.0.0.0.609.1-0ubuntu2.3) ...
Setting up doca-ofed-26.01-dkms (26.01.1.0.0.0.609.1-0ubuntu2.3) ...
Loading new doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 DKMS files...
Building for 7.0.0-39-generic
Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for
7.0.0-39-generic
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der
Running the pre_build script.................. done.
Building module(s)....................... done.
Signing module
/var/lib/dkms/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-ofed-kernel/compat/mlx_compat.ko
Signing module
/var/lib/dkms/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-ofed-kernel/drivers/fwctl/mlx5/mlx5_fwctl.ko
Signing module
/var/lib/dkms/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-ofed-kernel/drivers/infiniband/core/ib_core.ko
=============
** Description changed:
SRU Justification
[ Impact ]
After cherry picking upstream commit a6e4b9a6deb9362ef7a0706c70d674e92fe1411a
("xsk: honor XDP_TX_METADATA in zero-copy path") the file
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c in mlnx-ofed-kernel
stopped compiling
as now the called API needs 3 parameters instead of 2.
[ Fix ]
To fix, a check during the configure phase is needed, and at that point a
discriminant
to decide whether to use 2 or 3 parameters will generate the right call.
[ Regression potential ]
If not correctly used, the 3rd parameter might introduce a but, but this is
considered
almost as none, as desc.option exists in the pre-existing environment
[ Build artifacts ]
Build artifacts can be found at
https://launchpad.net/~alessiofaina/+archive/ubuntu/doca-
- ofed-3.4-resolute-ubuntu3-prerelease/+packages
+ ofed-26.10-resolute-ubuntu2.3/+packages
[ Build failure detail ]
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c: In function
‘mlx5e_xsk_tx’:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:120:24: error: too few
arguments to function ‘xsk_buff_get_metadata’; expected 3, have 2
- 120 | meta = xsk_buff_get_metadata(pool, desc.addr);
- | ^~~~~~~~~~~~~~~~~~~~~
+ 120 | meta = xsk_buff_get_metadata(pool, desc.addr);
+ | ^~~~~~~~~~~~~~~~~~~~~
In file included from
/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-3.4-dkms/3.4.0+0.8.5.0/build/mlnx-ofed-kernel/include/net/xdp_sock_drv.h:7,
- from drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:10:
+ from drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:10:
/usr/src/linux-headers-7.0.0-39-generic/include/net/xdp_sock_drv.h:332:1:
note: declared here
- 332 | xsk_buff_get_metadata(struct xsk_buff_pool *pool, u64 addr, u32
options)
- | ^~~~~~~~~~~~~~~~~~~~~
+ 332 | xsk_buff_get_metadata(struct xsk_buff_pool *pool, u64 addr, u32
options)
+ | ^~~~~~~~~~~~~~~~~~~~~
make[7]: ***
[/usr/src/linux-headers-7.0.0-39-generic/scripts/Makefile.build:289:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.o] Error 1
make[7]: *** Waiting for unfinished jobs....
** Patch added: "resolute-doca-ofed-26.01.patch"
https://bugs.launchpad.net/ubuntu/+source/doca-ofed-26.01-dkms/+bug/2169605/+attachment/6005968/+files/resolute-doca-ofed-26.01.patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2169605
Title:
doca-ofed- stops building after cherry pick of upstream commit
a6e4b9a6deb9362ef7a0706c70d674e92fe1411a
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/doca-ofed-26.01-dkms/+bug/2169605/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
