** Description changed:
SRU Justification
[ Impact ]
After cherry picking upstream commit a6e4b9a6deb9362ef7a0706c70d674e92fe1411a
("xsk: honor XDP_TX_METADATA in zero-copy path") the file
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c in mlnx-ofed-kernel
stopped compiling
as now the called API needs 3 parameters instead of 2.
+
+ [ Test case ]
+
+ Compile test against the latest kernel with the cherry-picked commit and
against a previous kernel without the commit to validate the DKMS will be able
to be
+ compiled on both cases.
[ Fix ]
To fix, a check during the configure phase is needed, and at that point a
discriminant
to decide whether to use 2 or 3 parameters will generate the right call.
[ Regression potential ]
If not correctly used, the 3rd parameter might introduce a but, but this is
considered
almost as none, as desc.option exists in the pre-existing environment
[ Build artifacts ]
Build artifacts can be found at
https://launchpad.net/~alessiofaina/+archive/ubuntu/doca-
ofed-3.4-resolute-ubuntu3-prerelease/+packages
[ Build failure detail ]
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c: In function
‘mlx5e_xsk_tx’:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:120:24: error: too few
arguments to function ‘xsk_buff_get_metadata’; expected 3, have 2
120 | meta = xsk_buff_get_metadata(pool, desc.addr);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from
/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-3.4-dkms/3.4.0+0.8.5.0/build/mlnx-ofed-kernel/include/net/xdp_sock_drv.h:7,
from drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:10:
/usr/src/linux-headers-7.0.0-39-generic/include/net/xdp_sock_drv.h:332:1:
note: declared here
332 | xsk_buff_get_metadata(struct xsk_buff_pool *pool, u64 addr, u32
options)
| ^~~~~~~~~~~~~~~~~~~~~
make[7]: ***
[/usr/src/linux-headers-7.0.0-39-generic/scripts/Makefile.build:289:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.o] Error 1
make[7]: *** Waiting for unfinished jobs....
** Description changed:
SRU Justification
[ Impact ]
After cherry picking upstream commit a6e4b9a6deb9362ef7a0706c70d674e92fe1411a
("xsk: honor XDP_TX_METADATA in zero-copy path") the file
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c in mlnx-ofed-kernel
stopped compiling
as now the called API needs 3 parameters instead of 2.
[ Test case ]
- Compile test against the latest kernel with the cherry-picked commit and
against a previous kernel without the commit to validate the DKMS will be able
to be
+ Compile test against the latest kernel with the cherry-picked commit and
against
+ a previous kernel without the commit to validate the DKMS will be able to be
compiled on both cases.
[ Fix ]
To fix, a check during the configure phase is needed, and at that point a
discriminant
to decide whether to use 2 or 3 parameters will generate the right call.
[ Regression potential ]
If not correctly used, the 3rd parameter might introduce a but, but this is
considered
almost as none, as desc.option exists in the pre-existing environment
[ Build artifacts ]
Build artifacts can be found at
https://launchpad.net/~alessiofaina/+archive/ubuntu/doca-
ofed-3.4-resolute-ubuntu3-prerelease/+packages
[ Build failure detail ]
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c: In function
‘mlx5e_xsk_tx’:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:120:24: error: too few
arguments to function ‘xsk_buff_get_metadata’; expected 3, have 2
120 | meta = xsk_buff_get_metadata(pool, desc.addr);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from
/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-3.4-dkms/3.4.0+0.8.5.0/build/mlnx-ofed-kernel/include/net/xdp_sock_drv.h:7,
from drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c:10:
/usr/src/linux-headers-7.0.0-39-generic/include/net/xdp_sock_drv.h:332:1:
note: declared here
332 | xsk_buff_get_metadata(struct xsk_buff_pool *pool, u64 addr, u32
options)
| ^~~~~~~~~~~~~~~~~~~~~
make[7]: ***
[/usr/src/linux-headers-7.0.0-39-generic/scripts/Makefile.build:289:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.o] Error 1
make[7]: *** Waiting for unfinished jobs....
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2169596
Title:
doca-ofed-3.4 stops building after cherry pick of upstream commit
a6e4b9a6deb9362ef7a0706c70d674e92fe1411a
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/doca-ofed-3.4-dkms/+bug/2169596/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
