I've got a bunch of nits; the only two blockers for me here are the version number and changelog entry. Thanks for the work!
Impact: +1 Test plan: The affected code is run by `kcm_process_init` before the responder drops into its main loop so this codepath is exercised by the test plan. I'm assuming that the expected behavior for the fixed package is for the responder to start and drop into its main loop (wait forever). It would be nice to include a description of what we're expecting to see from the fixed package. Where problems could occur: The regression you describe here is IMO better than the use-after-free, but could be an unpleasant surprise for a user. What might a user affected by this case have to do to troubleshoot and/or resolve the problem? (edit the config file?) Code change: trivial, LGTM Patch/DEP-3: I try to use the LP bug's short form for Bug-Ubuntu: https://bugs.launchpad.net/bugs/2169162. Changelog: - As Seyeong requested, can you propose a version number for the upload? (docs at [1]) - How could a user who isn't a C programmer evaluate whether they want to install this update? What is the impact of the use-after-free? The patch description tells us what changed, the changelog entry should tell us why. - You don't need to include [ Maizi Liao ] over your entry when you're the only one making changes - This is completely optional, but I like to use the top-level bullet of the changelog for my short description & LP bug reference and then list the patches as sub-bullets (as you did in your lldpd uploads [2]) [1] https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/version-strings/ [2] https://launchpad.net/ubuntu/+source/lldpd/1.0.18-1ubuntu0.1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2169162 Title: sssd-kcm fails to start due to use-after-free with krb5_renew_interval To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/2169162/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
