Hello again, Asa! After side conversation from last week, I have digged deeper in the package using the new review skill[1] so the AI would help checking the package. You can use the same skills to do auto-reviews in the future (:
I had two comments before that: - the package should not be named -defaults, as this would generally be used for metapackages for dependency resolution in Ubuntu - We would need an explanation on how the contents are not breaking general installation (people who "just" install the package on their system see no harm and, if harm is expected, there is a clear rollback) - the AI report helped with specificities here. Please address the topics below, either by fixing them or justifying when it's needed, for clarity (mainly the implementation ones). FWIW the (adapted) packaging report summarizes to: 1. `postinst` fails when `configure` runs a second time. It calls `groupadd drpai` without checking whether the group exists. Under `set -e`, an upgrade or `dpkg-reconfigure` then fails because the group is already there. It also makes a normal group rather than a system group. Suggested fix: guard it with `getent group drpai >/dev/null || groupadd --system drpai`, or ship a `sysusers.d` file. 2. The dependency can't be installed in stonking. It needs linux-image- renesas (>= 6.8.0-1005.5), which exists only in noble-updates/universe (arm64). rmadison shows nothing for stonking or resolute, so the package can't be installed or migrated there. 3. Architecture: any is wrong. Nothing in the package depends on the architecture (lintian: package-contains-no-arch-dependent-files). It would build an amd64 package whose dependency can't be met. Since it's hardware-specific, use arm64; otherwise all. 4. Some dependencies are never used. Nothing uses acl or sysfsutils. initramfs-tools is only there for the manual dpkg-trigger update- initramfs, and that call has no clear purpose. If it's needed, use a debian/triggers file with activate-noawait update-initramfs. 5. debian/copyright is broken. - The CC0-1.0 stanza is copy-pasted and says the "GNU General Public License version 3" text is in CC0-1.0. - The license versions don't agree: copyright says GPL version 3 only, the grub cfg header says GPL-3.0+, and the metainfo uses the deprecated SPDX ID GPL-3.0. Pick one, e.g. GPL-3.0-only. - The holder should be Canonical Ltd., not Canonical. - There is trailing whitespace after Files: *. - lintian also warns inconsistent-appstream-metadata-license. 6. debian/rules has leftover cruft. dh_installsystemd --name=postboot- optimization names a unit that doesn't exist. override_dh_install just calls dh_install and does nothing extra. Consider removing both. Besides the packaging, the agent found some implementation considerations: 1. The metainfo hardware patterns never match. The kernel builds these strings as of:N<name>T<type>C<compatible> (checked in scripts/mod/file2alias.c). The patterns of:N*Trenesas,... are missing the *C part. They should be of:N*T*Crenesas,r9a07g044-drpai* and so on. 2. The fwupd timer drop-in may not do what the bug says. OnBootSec=5min adds a trigger but leaves the stock OnCalendar + Persistent=true in place. A missed run can still fire right at boot. If the goal is to stay out of the boot storm, reset OnCalendar= and/or set Persistent=false, then confirm on the board. README.debian also calls this "firmware updates", but the timer only refreshes metadata. 3. GRUB: - GRUB_CMDLINE_LINUX_DEFAULT="" replaces the whole default, not just quiet/splash. - The file is a conffile, so it stays after remove until purge. That means the update-grub in postrm remove still applies it. - Removing quiet in an archive package needs to be a deliberate choice. 4. udev: udmabuf is a generic kernel device, not a Renesas one. Giving it to group drpai plus uaccess deserves a brief security note. Both rule files lack a trailing newline. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2151177 Title: [needs packaging] renesas-iot-defaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2151177/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
