** Description changed:

- https://github.com/ubuntu/adsys/pull/1494
+ [ Impact ]
+ 
+ The adsys package for Resolute, Noble, and Jammy intermittently fails to build
+ as a result of test failures due to flaky tests. Five distinct failure modes
+ were observed:
+ 
+ - The integration tests connected to mock system daemon containers before 
their
+   D-Bus sockets and polkitd were ready, failing with authorization errors on
+   loaded builders
+ 
+ - "adsysctl service cat" occasionally hung until the test suite hit its
+   10-minute timeout, due to a deadlock in the stdout/stderr forwarding 
teardown
+ 
+ - Policy scripts were intermittently not run at all, with only an ETXTBSY
+   warning in the logs
+ 
+ - The watcher grace period test failed on slow or I/O-loaded machines
+ 
+ - dconf golden-file comparisons failed on big-endian architectures (s390x),
+   where binary dconf databases have a byte-swapped signature
+ 
+ This was addressed upstream in adsys 0.17.0. Commits [1][2][3][4] landed via a
+ single upstream PR [6], and commit [5] later.
+ 
+ The fix backports those five upstream commits [1][2][3][4][5]. This SRU is
+ needed to fix builds for the original bug (LP: #2169074).
+ 
+ [ Test Plan ]
+ 
+ The upstream test suite runs during the package build, and the package also
+ ships autopkgtests that run it again.
+ 
+ - The package must build successfully on all supported architectures in
+   -proposed for Resolute, Noble and Jammy
+ 
+ - The autopkgtests must pass on all architectures
+ 
+ - Test packages were built for each affected release and are available in the
+   following PPA: https://launchpad.net/~munirsid/+archive/ubuntu/lp2169074/
+ 
+ [ Where problems could occur ]
+ 
+ The regression potential is low. Three of the five commits only change tests
+ and test helpers. Two commits touch shipped code:
+ 
+ - The stdforward change reworks the locking when stdout/stderr forwarding is
+   torn down. If wrong, log forwarding to "adsysctl service cat" clients could
+   hang or lose buffered output. The change is covered by new regression
+   tests exercising the teardown races.
+ 
+ - The scripts change retries policy scripts that fail with ETXTBSY up to 5 
times
+   with a 100 ms delay. In the worst case, a persistently busy script is 
reported
+   as failed about 0.5 s later than before. The success path is unchanged.
+ 
+ Any mistake in the test-only changes would be caught at build time or by the
+ autopkgtests, before the package reaches users.
+ 
+ [ Other Info ]
+ 
+ - The fix for this bug will be bundled with the fix for LP: #2169074 into a
+   single package upload. The debdiffs will be uploaded and attached to the 
main
+   bug report in LP: #2169074.
+ 
+ - For Resolute, commits [3][4][5] were already released in 0.16.4ubuntu1.2 and
+   0.16.4ubuntu1.3, so the Resolute upload only adds [1] and [2]. Noble and 
Jammy
+   get all five.
+ 
+ - Packages in Stonking and later releases already have the fix.
+ 
+ [1] - 
https://github.com/ubuntu/adsys/commit/cad0146a2fb65ed2043f392f1e71cc42963b40ed
+ [2] - 
https://github.com/ubuntu/adsys/commit/1723a9c2232cad5ce6e35aa7c66b32852868ea07
+ [3] - 
https://github.com/ubuntu/adsys/commit/af422e78e591fcdb59982bece9b15767a1693a15
+ [4] - 
https://github.com/ubuntu/adsys/commit/deda81651ead9f20801203c8ca7c32cde76b9418
+ [5] - 
https://github.com/ubuntu/adsys/commit/4d691ea5ec772c73cbef492e74cde21fa1fbd4e5
+ [6] - https://github.com/ubuntu/adsys/pull/1494

** Summary changed:

- Flaky tests cause build failures
+ adsys build occasionally fails due to flaky tests

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2174567

Title:
  adsys build occasionally fails due to flaky tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/2174567/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to