Public bug reported:

[Impact]

On MT8901 systems whose speakers use Cirrus CS35L56 amplifiers on SoundWire,
the amplifiers never load their system-specific firmware or speaker tuning.
They run their ROM firmware untuned on every such system.

The cs35l56 driver picks its firmware and tuning files by a system name. On
x86 the ASoC core takes that name from the sound card's PCI subsystem ID. The
MT8901 sound card has no PCI parent and no cirrus,firmware-uid property, so
no system name is set and no per-system files are requested.

The platform firmware does publish the OEM subsystem ID, as ACPI _SUB on the
SoundWire controller node (on one design, on the audio front-end node). The
kernel does not read it.

[Fix]

NVIDIA: SAUCE: ASoC: mediatek: mt8901: set the card SSID from the ACPI
subsystem ID

The MT8901 SoundWire machine driver reads _SUB from the SoundWire controller,
falling back to the audio front-end node. It decodes the SUBSYS-order string
(device first, vendor last) and sets it as the card's subsystem ID with
snd_soc_card_set_pci_ssid(). The cs35l56 driver then requests the same
"<vendor><device>" firmware and tuning names as on x86, so the tuning files
can be published under the usual linux-firmware layout. Systems without a
_SUB keep the current behaviour.

The mt8901 machine driver is not in mainline yet. The change is folded into
MediaTek's pending upstream submission of the driver, and the SAUCE commit
will be replaced by the backport once that lands.

This fix is proposed for Ubuntu 26.04 linux-nvidia-bos and the linux-nvidia
7.3 (26.04 HWE) kernel.

[Test Plan]

On MT8901 systems with Cirrus CS35L56 amplifiers:

 * Confirm the sound card reports the OEM subsystem ID from ACPI _SUB.
 * Confirm the cs35l56 driver requests the vendor- and device-named firmware
   and tuning files.
 * On systems without _SUB, confirm the card registers as before.

[Where problems could occur]

The change is confined to the MT8901 SoundWire machine driver, and the only
consumer of the card subsystem ID is the cs35l56 driver. Systems without _SUB
are unaffected. A malformed _SUB is logged and ignored. If the published
subsystem ID were wrong, cs35l56 would request firmware files that do not
exist and stay on its ROM firmware, which is the current behaviour.

** Affects: linux-nvidia (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2174615

Title:
  mt8901: Cirrus CS35L56 speaker amplifiers load no system-specific
  firmware or tuning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2174615/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to