d-i upstream is currently in a string freeze, so I think at the moment it is best to do this just in Ubuntu and simply omit internationalisation for the time being. I have queued this up in my Debian working tree for after the d-i beta release.
Some comments on your patch: * Please try to avoid changing tab widths, and stick with the tab width already used in the file you're editing. Changing everything from hard tabs to two-space tabs made the patch much harder to read. * On a similar note, I think it's best to omit automatic changes to .po files from patches, and simply include directions on how to reproduce them. They make the patch very large and hard to read. In the case of submitting patches to d-i, they should always be omitted since the d-i project has its own automatic systems for keeping .po files up to date and does not expect them to be touched by developers. * My inclination is that network-console/authorized_keys_url should not be asked at all, but simply provided for preseeding. (Thus, omit db_input and db_go, and just leave the db_get in there.) I can't really imagine the sorts of people who would want this stepping all the way through in expert mode, and your own description mentions preseeding rather than interactive use. Do you agree? * I made some trivial quoting changes, and adjusted the text of the retrieval failure error to make use of a common "see syslog"-type string in order to allow sharing translations with other parts of d-i. * ssh itself creates ~/.ssh as mode 0700; I don't think it actually matters much but I changed that from 0755. Conversely, it's perfectly fine for authorized_keys to be 0644. (None of this really makes a lot of difference in d-i, of course.) * The retrieval error message should have the URL substituted into it, and should actually be displayed using db_go. I think that network- console should also bail out if this error occurs, rather than continuing merrily along. * Preseed files are fetched using 'wget -q'; I think this should be the same. I've attached the updated patch for your reference. The rest of it looks fine to me, and I'll upload this to Hardy shortly. Thanks a lot! ** Attachment added: "network-console.184108.patch" http://launchpadlibrarian.net/11754929/network-console.184108.patch -- Provide Support for Public Key/Authorized Keys-based Authentication When Password Seeding in Preseed is Undesirable https://bugs.launchpad.net/bugs/184108 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
