Upstream sent me the following:

*****
I finished my libgda3 patch. At 81K it's a rather big one:
http://www.kfk4ever.com/~griffon26/shared/planner-libgda3-fixes.patch

To summarize the changes:

- configure.in and two Makefile.am's were modified to detect the libgda
 version and pass -DGDA_VERSION=NN to the compiler

- previously all sql commands were done through a single function, but
 that is now split up into one for single queries returning data and
 one for possibly multiple commands, returning only success/failure

- return value checking is now done consistently (I think we leaked some
 GdaDataModels here and there before)

- After moving some code back and forth, the sql helper functions at the
 top of mrp-sql.c and planner-sql-plugin.c are now identical (as they
 should be). I didn't feel it would add much to move them into a
 separate shared file, unless there's already such a shared file that
 I'm not aware of (?).

I invite anyone to give this patch some testing. It's all about database
access, so you'll have to pass --enable-database=yes to configure when
building.

If nobody objects, I plan to check in this patch in a week or so.

Maurice.
*****

As seen above, the patch is actually fairly intrusive. I am thus
wondering whether we should dare release it for Hardy. On the plus side,
we'd regain database support for the next two years, meaning that those
who upgrade from the last LTS would not loose database support. On the
minus side, this patch could use proper peer review before it's merged.

-- 
Planner needs transition from libgda2-dev to libgda3-dev
https://bugs.launchpad.net/bugs/182941
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to