On Sat, Mar 8, 2008 at 8:14 PM, Shawn Smith <[EMAIL PROTECTED]> wrote: > Here is the final init script, with (hopefully) fixed tabs.
Hi Shawn- You're nearly there... A couple of things left. * The log_*_msg lines inside of the if/else are not indented properly * You attached the script again... We always deal in diffs and patches! :-) * Speaking of diffs and patches... You're proposing that this change be accepted into Ubuntu. For that to happen (more easily), you should really attach a debdiff. Here are detailed instructions that I used to generate a proper debdiff from your code. * mkdir -p /work/source/samba # Make a working directory. Perhaps /work/source/samba * cd /work/source/samba # go to that directory * apt-get source samba # grab the source of samba * wget http://launchpadlibrarian.net/12504891/samba_status.patch # grab your patch * cd samba-*/debian/ # go to the unpacked directory * patch < ../../samba_status.patch # apply your patch * At this point, this patch has some bad white space problems, I'm going to manually fix those for you * cd .. # back one directory * dch -i # Add a changelog entry describing your changes. This format is VERY VERY VERY particular. Look at the other entries and try to follow those. * Notice that the -i will increment the version. Notice the indentation on the changes, followed by asterisk bullets. Notice that the file name that was changed, followed by a colon, then a description of the rationale for the changes. Because I'm creating the debdiff, my name and email address appear at the bottom of the changes. Since you did the hard work, I added a line giving you credit for the initial patch ;-) Finally, notice the (LP: XXXXXX), That part is very important. This is how bugs get closed by patches. It must match that format exactly. * Save and quit * apt-get install build-essential # get the build tools * apt-get build-dep samba # get the build dependencies for samba * debuild -uc -us # test building a new build, ~10 minutes * debdiff > ../samba_status.diff * Have a look at samba_status.diff, note that ONLY the desired changes are present, and give the changelog another look over, for grammar, spelling, and format. * You would attach that debdiff here (I've attached this one) There are many, many service scripts in /etc/init.d that are missing "status" sections. Perhaps you might want to try your hand at another one? Open a separate bug of course. :-Dustin -- Samba initscript does not conform to the LSB Spec. https://bugs.launchpad.net/bugs/39157 You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
