Pedro, I ran interdiff -z -p1 vino_2.23.90-0ubuntu1.diff.gz
vino_2.23.91-0ubuntu1.diff.gz and saw this:
--- vino-2.23.90/debian/control.in
+++ vino-2.23.91/debian/control.in
@@ -22,13 +22,14 @@
libdbus-glib-1-dev,
libnotify-dev (>= 0.4.4),
libnotify-dev-gtk2.10,
- libgnome-keyring-dev
+ libgnome-keyring-dev,
+ libdbus-1-3 (>= 1.2.3)
Standards-Version: 3.7.3
.
Package: vino
Architecture: any
Depends: ${shlibs:Depends},
- ${misc:Depends}
+ ${misc:Depends},.........
Suggests: vinagre,
gnome-user-guide | gnome2-user-guide (>= 2.8.1)
Description: VNC server for GNOME
1) You added whitespaces needlessly to the vino deps, be careful.
2) Upstream added checks on the dbus-1 pkg-config module:
-PKG_CHECK_MODULES(VINO_SERVER, glib-2.0 >= $GLIB_VERSION gtk+-x11-2.0 >=
$GTK_VERSION gconf-2.0 libglade-2.0 libbonobo-2.0 dbus-glib-1)
+PKG_CHECK_MODULES(VINO_SERVER, glib-2.0 >= $GLIB_VERSION gtk+-x11-2.0 >=
$GTK_VERSION gconf-2.0 libglade-2.0 dbus-1 >= $DBUS_VERSION dbus-glib-1
libgnomeui-2.0)
.
-PKG_CHECK_MODULES(VINO_CAPPLET, glib-2.0 >= $GLIB_VERSION gtk+-2.0 >=
$GTK_VERSION gconf-2.0 libglade-2.0 dbus-glib-1)
+PKG_CHECK_MODULES(VINO_CAPPLET, glib-2.0 >= $GLIB_VERSION gtk+-2.0 >=
$GTK_VERSION gconf-2.0 libglade-2.0 dbus-1 >= $DBUS_VERSION dbus-glib-1)
this means that you need to build-dep on the package providing
dbus-1.pc; it is NOT libdbus-1-3
3) you missed the fact that the orbit2 / libbonobo pkg-config modules
checks were dropped, but this is visible in the diff of configure.ac AND
mentionned in the ChangeLog file
4) style: you mention the libgnomeui-dev build-dep as a separate change:
+ * New upstream release (LP: #263738)
+ - Make vino work correctly with new gnome-session. (Jonh Wendell)
+ * debian/control.in:
+ - Add B-d on libgnomeui-dev
but it's actually related to the new upstream release; I recommend you mention
it along the upstream release.
5) you didn't actually add this build-dep......
** Changed in: vino (Ubuntu)
Assignee: (unassigned) => Pedro Fragoso (ember)
Status: New => Incomplete
--
Please sponsor vino 2.23.91 (main) into Intrepid
https://bugs.launchpad.net/bugs/263738
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
