See the inline diff for the added-symbol.
I'd like to have a SRU upload without it since we don't need to use anywhere 
else

Diff comments:

> diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols
> index 1489074..89b3d01 100644
> --- a/debian/libmutter-2-0.symbols
> +++ b/debian/libmutter-2-0.symbols
> @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER#
>   meta_gpu_kms_error_quark@Base 3.28.2
>   meta_gpu_kms_flip_closure_container_free@Base 3.28.3+git20190124
>   meta_gpu_kms_flip_crtc@Base 3.28.2
> + meta_gpu_kms_get_current_time_ns@Base 3.28.3+git20190124-0ubuntu18.04.3

Mhmmh, the fact we've a new symbol would probably be seen as packaging level as 
something would need an ABI bump...

So, since this symbol isn't used anyway, couldn't maybe just make sure this is 
hidden and not exported (adding some inline things or maybe is just fine to 
rename is with a leading '_' for this branch)?

>   meta_gpu_kms_get_fd@Base 3.28.2
>   meta_gpu_kms_get_file_path@Base 3.28.2
>   meta_gpu_kms_get_max_buffer_size@Base 3.28.2


-- 
https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362
Your team Ubuntu Desktop is requested to review the proposed merge of 
~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into 
~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic.

-- 
ubuntu-desktop mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop

Reply via email to