On Sun, Sep 10, 2017 at 11:42:59AM +0200, Julian Andres Klode wrote: > On Sun, Sep 10, 2017 at 10:01:27AM +0100, Colin Watson wrote: > > Note that we'd need to get > > https://code.launchpad.net/~cjwatson/launchpad-buildd/apt-lists/+merge/286751 > > reviewed and landed before doing this, or dep-wait analysis of failed > > builds will break. > > I should mention that you don't need apt-helper, but can just pass > a file name to apt_pkg.TagFile and it handles decompression, starting > with libapt-pkg4.12 (which is about apt 1.0.9 I think?).
I deliberately chose to use apt-helper instead, because it ensures that we're using tools from the chroot to parse files in the chroot, which is usually a good idea for robustness. If we used apt_pkg.TagFile outside the chroot, then we'd be reliant on python-apt in the buildd host system (i.e. a fixed Ubuntu series) being able to handle whatever formats are used in the chroot, which may be true now but seems a poor assumption to make in the long term. That said, if you think that would really be a better way to go about it, then please leave it as a comment on the MP otherwise we'll probably forget. -- Colin Watson [[email protected]] -- ubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
