On 12 December 2010 10:07, Michael Bienia <[email protected]> wrote: > On 2010-12-11 09:24:37 -0500, Barry Warsaw wrote: >> So, I actually find these notifications less helpful than they could be. I'm >> used to being on various "-checkins" mailing lists where every change to a >> tree is included in the notification in unidiff format. This is a great, low >> impact way, to monitor what's happening to code you care about. It's also a >> cheap way to propagate post-commit review of changes. It's not uncommon for >> example to see a Python commit be questioned and adjusted after the fact >> (that's why we have a vcs, right? :). >> >> I would love to see the same thing in these -changes notifications. > > I could live with a link to the generated LP diff or a link to the > commit in the packaging branch for easier access but please don't > include the whole diff in the -changes mail as I prefer to have them > small. > For an ubuntuX → ubuntuX+1 upload the diff will most likely be only a > few kB but for an upload of a new upstream version the diff can be > several hundred kB or even some MB. I don't want to have such huge diffs > attached to the -changes email as I certainly won't read such big diffs > (and especially won't read diffs of generated files like configure or > updates of line numbers in translation templates). >
The launchpad codehosting can limit the diff to e.g. 1000 lines. We are really interested in full debian/ diff and directly applied patches the rest is less important when it is new upstream release. >> How hard would it be to do that? > > As the -changes mail gets generated when the upload gets accepted that > would probably delay them if they need to wait on the diff. > How long does it take till the diff between two uploads is available in > LP? > > Michael > > -- > ubuntu-distributed-devel mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel > -- ubuntu-distributed-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel
