(CC'ing [email protected], so other interested parties can participate in the discussion)
On Sat, Sep 12, 2009 at 3:12 PM, Roman Shtylman <[email protected]> wrote: > I have updated the copyright info for the icons and also merged in > content changes from another kubuntu dev. The slides are ready to be > merged in (I hope). > > We are hoping that could happen soon to get the slides in and tested > before the next alpha. > > lp:~shtylman/ubiquity-slideshow-ubuntu/kubuntu-slideshow Thanks for making those changes. I am not keen on the approach of maintaining copies under kubuntu/ of only a slightly modified part of the javascript library, the rest of it completely unmodified, and some of the slides. If we make the smallest of changes, we have to make them in two places, and my experience with oem-config and ubiquity leads me to believe that we'll often forget. Can you not refactor this so the modification is layered on top of the common code, and that shared pages are generated in both build directories at build time? You're missing a copyright notice for the Kubuntu logo. Also, I would argue that we shouldn't keep the UI files in this package. It should simply be content viewable in a browser, not a special widget. Leave the task of creating a UI to ubiquity. Thanks, Evan -- Ubuntu-installer mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-installer
