Hi Shafiei, Some feedback:
- please create a debian/watch file that says where to get (updates to) the upstream source. I was able to work out where to find the upstream tarball by looking at debian/copyright, but ideally this would be much more automatic. (debian/watch file syntax is documented in the uscan(1) manpage, but it is non-trivial; https://lists.debian.org/debian-mentors/2022/04/msg00052.html might be a useful starting point.) - "Description" in debian control is malformatted. The description field consists of a single-line short description (should fit under 72 characters) followed by an indented paragraph for the long description. The way you have this formatted currently, is a 700-character short description which will break display. (Running the lintian command over your built package would catch this error.) - you have the package marked as Architecture: any, but this means the package is built separately for each architecture - you do not have any architecture-specific contents here so the package should be Architecture: all - debian/copyright declares https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ but does not follow the format. Your License: field should consist of a single one-word name for the license, followed by indented paragraphs. Continuation across multiple paragraphs should be encoded as ' .', not as a blank line. According to https://spdx.org/licenses/ the preferred short name for the license used here is OFL-1.1. - you list yourself as the upstream contact in debian/copyright but it is not clear to me why. You are not listed in the upstream AUTHORS.txt and https://gitlab.flossir.org/rshf who maintains the git repository is not obviously you. - font packages should be declared 'Multi-Arch: foreign' for maximum compatibility. (This issue was also identified by lintian.) If you address the above issues in the packaging, I am happy to sponsor this package into the Ubuntu archive for the upcoming kinetic release. On Fri, Aug 26, 2022 at 10:56:10AM +0430, A. Shafiei wrote: > Hello everyone, > > There are a number of fonts for Persian language which I am trying to > package. The first one is the Vazirmatn font. > > I would like to know if anyone could please review this package: > > https://code.launchpad.net/~farsi-fonts/+junk/fonts-vazirmatn > > https://launchpad.net/~farsi-fonts/+archive/ubuntu/farsi-fonts/+packages > > Thanks in advance. > Shafiei > -- > Ubuntu-motu mailing list > Ubuntu-motu@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
-- Ubuntu-motu mailing list Ubuntu-motu@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu
