** Description changed: ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) - regression potential: there should be none. However, I am concerned - as to how this happened, as the package build should have failed with - this whitespace damage. + regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. ==================================== The source package for spice contains a malformed patch such that dpkg- source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself.
** Description changed: ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) - regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. + regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. However, this change has been in wheezy-backports for a long time with no reported troubles. ==================================== The source package for spice contains a malformed patch such that dpkg- source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to spice in Ubuntu. https://bugs.launchpad.net/bugs/1450043 Title: spice package for trusty contains a malformed patch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/spice/+bug/1450043/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
