On Thu, Dec 5, 2019 at 6:06 AM Steve Langasek <steve.langa...@ubuntu.com> wrote: > > On Wed, Dec 04, 2019 at 04:33:33PM -0800, Bryce Harrington wrote: > > postgresql-common -> php-horde-db > > - autopkgtest is failing during database setup: > > PHP Fatal error: Declaration of Horde_Db_Adapter_TestBase::setUp() > > must be compatible with PHPUnit\Framework\TestCase::setUp(): void in > > > > /tmp/autopkgtest.lh5Xz0/build.jTq/src/Horde_Db-2.4.0/test/Horde/Db/Adapter/TestBase.php > > on line 1184 > > - No fix evident in Debian's php-horde-db yet. > > - Poking around, best guess is this is caused by the phpunit 8.4.3 > > that has hit focal-proposed. In phpunit8, setUp() functions need to > > have a ": void" specified in order to match the base class decl. > > I've not verified this fixes the tests, but it seems likely. > > Looks like 7 test cases need updated. Guessing other php packages > > could be similarly affected. Ref.: > > + https://thephp.cc/news/2019/02/help-my-tests-stopped-working > > + > > http://laravel-school.com/posts/php-fatal-error-declaration-of-teststestcasesetup-must-be-compatible-36 > > If it's caused by an unrelated package in focal-proposed, then the way to > clear the blockage is to not test against that unrelated package, only the > packages from -proposed that you are trying to get migrated.
IMHO that is https://bugs.horde.org/ticket/14964 horde-db is incompatible to PG12 proposed fix in https://github.com/horde/Db/pull/4 @Bryce you could bump that upstream PR or try to add a temporary Delta with the fix proposed in there? > But that is what proposed-migration does by default, and the php-horde-db > tests when running against only postgresql-common from -proposed also > failed: > https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/p/php-horde-db/20191114_225401_50d19@/log.gz > > -- > Steve Langasek Give me a lever long enough and a Free OS > Debian Developer to set it on, and I can move the world. > Ubuntu Developer https://www.debian.org/ > slanga...@ubuntu.com vor...@debian.org > -- > ubuntu-server mailing list > firstname.lastname@example.org > https://lists.ubuntu.com/mailman/listinfo/ubuntu-server > More info: https://wiki.ubuntu.com/ServerTeam -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd -- ubuntu-server mailing list email@example.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-server More info: https://wiki.ubuntu.com/ServerTeam