Alan Pope has proposed merging lp:~popey/ubuntu-calendar-app/reduce-typing
into lp:ubuntu-calendar-app.
Commit message:
Shorten text to reduce test run duration.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~popey/ubuntu-calendar-app/reduce-typing/+merge/260716
The AP tests spend a fair amount of time typing in long UUIDs. Shorter (8 char)
UUIDs are unique enough and reduce typing immensely. Given many tests type the
same UUID in 3 times, we can save a good bunch of minutes on each test run by
shortening the text.
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~popey/ubuntu-calendar-app/reduce-typing into lp:ubuntu-calendar-app.
=== modified file 'tests/autopilot/calendar_app/data.py'
--- tests/autopilot/calendar_app/data.py 2014-07-30 21:45:13 +0000
+++ tests/autopilot/calendar_app/data.py 2015-06-01 13:17:20 +0000
@@ -50,10 +50,10 @@
def make_unique(cls, unique_id=None):
"""Return a unique event."""
if unique_id is None:
- unique_id = str(uuid.uuid1())
+ unique_id = str(uuid.uuid4())[:8]
calendar = 'Personal'
- name = 'Test event {}'.format(unique_id)
- description = 'Test description {}.'.format(unique_id)
- location = 'Test location {}'.format(unique_id)
+ name = 'Test ev {}'.format(unique_id)
+ description = 'Test desc {}.'.format(unique_id)
+ location = 'Test loc {}'.format(unique_id)
guests = ['UX User']
return cls(calendar, name, description, location, guests)
=== modified file 'tests/autopilot/calendar_app/tests/test_data.py'
--- tests/autopilot/calendar_app/tests/test_data.py 2014-07-31 15:59:26 +0000
+++ tests/autopilot/calendar_app/tests/test_data.py 2015-06-01 13:17:20 +0000
@@ -25,7 +25,7 @@
event = data.Event.make_unique(unique_id='test uuid')
self.assertEqual(event.calendar, 'Personal')
- self.assertEqual(event.name, 'Test event test uuid')
- self.assertEqual(event.description, 'Test description test uuid.')
- self.assertEqual(event.location, 'Test location test uuid')
+ self.assertEqual(event.name, 'Test ev test uuid')
+ self.assertEqual(event.description, 'Test desc test uuid.')
+ self.assertEqual(event.location, 'Test loc test uuid')
self.assertEqual(event.guests, ['UX User'])
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
