Salaam,
On Sun, Jan 25, 2009 at 7:23 PM, Mohammad <[email protected]> wrote: > Salaam, > > On Sat, Jan 24, 2009 at 11:59 PM, أحمد المحمودي > <[email protected]> wrote: >> >> السلام عليكم، >> >> On Sat, Jan 24, 2009 at 07:36:13PM -0500, Mohammad wrote: >> > I uploaded the package here: >> > http://revu.ubuntuwire.com/details.py?package=zekr >> ---end quoted text--- >> >> * Why did you comment 'get-orig-source' in debian/rules ? > > They are changes which I made to zekr-0.7.2: > > Version 0.7.2 - (Linux Special Release) [24-1-09] > Features/Enhancements: > zekr's main directory name, zekr, changed to zekr-0.7.2 > dist/zekr-src.jar is unpacked to src/ > src/net/sf/zekr/common/util/Base64.java is removed since we depends on > commons-codec > res/audio/player.swf is removed due to its license issue. It should be > downloaded manually from > http://developer.longtailvideo.com/trac/export/133/tags/mediaplayer-3.12/mediaplayer.swf > by the end user. > > lib/commons-codec-1.3.jar,commons-configuration-1.5.jar,commons-lang-2.4.jar,log4j-1.2.8.jar,lucene-highlighter-2.3.2.jar,swt.jar,commons-collections-3.2.1.jar,commons-io-1.4.jar,commons-logging-1.0.4.jar,lucene-core-2.3.2.jar,lucene-snowball-2.3.2.jar,velocity-1.4.jar > are removed. These libraries should be provided by the target system. > The default translation, zekr/res/text/trans/yusufali.trans.zip, is > replaced by transliteration-en.trans.zip. > The license section of library dependencies is removed from readme.txt > res/ui/js/jquery.js is removed. jquery.js should be downloaded manually > from http://jquery.com/ > license details moved to doc/license.txt. > > Now that these changes were made I think we do not need get-orig-source in > debian/rules anymore since the original upstream of the deb package is > exactly http://zekr.org/download/zekr_0.7.2.orig.tar.gz > > > >> >> * In changelog, it is enough to have one empty line for spacing between >> lines. > > fixed that. > >> >> * Regarding warning notice in control, I think it is a bit misleading, >> because the user may opt to not download the FLV player > > I removed that. > >> >> * Since you used js-query package. Then maybe we should add that a line >> in get-orig-source to delete js-query.js script. > > in http://zekr.org/download/zekr_0.7.2.orig.tar.gz anything, including third > party libraries and javascsripts, which can be downloaded separately, are > removed. So jquery.js doesn't exist in the upstream so I didn't add its > removal to get-orig-source > >> >> * Regarding Scott Kitterman's comment on REVU. What he means is that: >> you just attach the zekr_0.7.2-0ubuntu1.diff.gz to the bug report >> #267412 in launchpad. Then they will get the orig tarball from >> upstream. > > ok, when we get ready with the package I will do that. > > >> >> Btw, why are you providing a special tarball at >> http://zekr.org/quran/quran-for-linux ? And why isn't 0.7.2 declared >> to be released on zekr.org ? > > Mohsen, is it possible to declare 0.7.2 a special release for developers? I > just added it at the end of http://zekr.org/quran/quran-for-linux without > chaning any other page. Sure. I'll send an email to our mailing list right now. > Thanks, > Mohammad > Mohsen. _______________________________________________ Mailing list: https://launchpad.net/~ubuntume.team Post to : [email protected] Unsubscribe : https://launchpad.net/~ubuntume.team More help : https://help.launchpad.net/ListHelp
