Joakim Tjernlund wrote: > Did a quick scan of the patches and came up with these comments:
While they tell me what you dislike, they don't really provide much in the way of alternatives. > The 02_underscores patch is really ugly. Any suggestions how to improve it? > Don't like the dl_find_hash_mod v.s dl_find_hash thingy. What do you dislike, and how would you do it differently? > +#if defined(DL_BOOT_COMPUTE_GOT) > + DL_BOOT_COMPUTE_GOT(got); > +#else > got = elf_machine_dynamic(); > +#endif > + > + /* Now, finally, fix up the location of the dynamic stuff */ > +#ifdef DL_BOOT_COMPUTE_DYN > + DL_BOOT_COMPUTE_DYN (dpnt, got, load_addr); > +#else > dpnt = (ElfW(Dyn) *) DL_RELOC_ADDR(load_addr, got); > +#endif What happens on the Blackfin is that the startup code computes these values and passes them down to the DL_START function. Hence, we need to just copy them from a function argument; calling elf_machine_dynamic doesn't do the trick. Bernd -- This footer brought to you by insane German lawmakers. Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif _______________________________________________ uClibc mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/uclibc
