Khem Raj wrote: > I dont see where the file got added after removing. > libc/sysdeps/linux/common/bits. indeed it's missing from the patch... strange.
> On Thu, Dec 4, 2008 at 5:41 AM, Carmelo AMOROSO <[EMAIL PROTECTED]> wrote: >> Carmelo AMOROSO wrote: >>> Carmelo AMOROSO wrote: >>>> Peter Kjellerstedt wrote: >>>>> Can anyone explain to me why kernel-features.h is placed in >>>>> libpthread/linuxthreads/sysdeps/pthread? As far as I can tell >>>>> there is nothing pthread related in that file. >>>>> >>>> Hi Peter, >>>> probably because it has been simply copied from glibc... your point seems >>>> correct to me. >>>>> This placement will prevent the changes made below by Carmelo in >>>>> libc/sysdeps/linux/common/getdents.c from taking effect for no >>>>> apparent reason at all if one uses libpthread/linuxthreads.old. >>>>> Moreover, if __ASSUME_GETDENTS32_D_TYPE actually happens to be >>>>> defined while compiling getdents.c when using >>>>> libpthread/linuxthreads I would say that is more of an accident >>>>> than anything else since there are no indications in the list of >>>>> included files that one is expecting kernel-features.h to be >>>>> included... >>>>> >>>> I'll try to find a better place where to include it. >>>>> //Peter >>>> Thanks, >>>> Carmelo >>> Hi, >>> well I've looed at this, I think the best way (ans easiest) is to move >>> kernel-features in libc/sysdeps/linux/common/bits and include it >>> from within features.h. >>> In this way, it will be included automatically in each file. >>> Let me know, so I can commit. >>> >>> Cheers, >>> Carmelo >>> >> Hi All, >> the attached patch try to address the issue raised by Peter. >> >> Let me know. >> Cheers, >> Carmelo >> >> _______________________________________________ >> uClibc mailing list >> [email protected] >> http://busybox.net/cgi-bin/mailman/listinfo/uclibc >> > _______________________________________________ > uClibc mailing list > [email protected] > http://busybox.net/cgi-bin/mailman/listinfo/uclibc > _______________________________________________ uClibc mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/uclibc
