-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bernhard Reutner-Fischer wrote: > On Wed, Jan 28, 2009 at 04:39:35PM +0100, Carmelo AMOROSO wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Folks, >> while reviewing test suite, found an issue in setting RPATH >> when TEST_INSTALLED_UCLIBC is not set. >> The attached patch should fix it. > Hi Bernhard, > Denys touched this in the meantime, i think? > yes, but he did not changed this part. Likely the patch does not apply now.
> PThe problem sounds like it's just coming from the testsuite not beeing > too well integrated into the in-tree (one could argue about whether it > should be more tightly coupled or purely freestanding, i.e. from outside > of libc. I'd prefer if it was not too intimately coupled, fwiw). > Not exactly... the issue you are opening it's real, but in this case I think it's different. I wanted just removing the ../../lib from the RPATH when using TEST_INSTALLED_UCLIBC, and setting RPATH=./ in all cases (while now is used only when building with TEST_INSTALLED_UCLIBC. Hoping now it's clearer. Regarding how much the test shuite should be coupled with the libc source tree, I agree with you that it should be decoupled, indeed using the installed_dir, treis to do extactly this, trating tests are user-sapce, stan-alone applications. Unfortunately this does not works at with NPTL and TLS tests (coming from nptl branch), because they were taken as is from the glibc where the tests are totally integrated into the source tree, and cannot be compiled from outside. I think that after merge, it should be reworked for being compilable as all others from outside. Cheers, Carmelo >> - -------- >> >> Build tests setting RPATH to ./ instead of $(top_builddir)lib >> to allow tests using their shared libraries to be loaded >> without setting LD_LIBRARY_PATH. >> When TEST_INSTALLED_UCLIBC is set, it doesn't need to set the RPATH, >> otherwise ass to the RPATH the $(top_builddir)lib too. >> UCLIBC_LDSO_ABSPATH is untouched. >> >> Signed-off-by: Carmelo Amoroso <[email protected]> >> >> Index: test/Rules.mak >> =================================================================== >> - --- test/Rules.mak (revision 25045) >> +++ test/Rules.mak (working copy) >> @@ -103,11 +103,13 @@ >> HOST_LDFLAGS += -static >> endif >> >> - -LDFLAGS += -B$(top_builddir)lib -Wl,-rpath,$(top_builddir)lib >> - -Wl,-rpath-link,$(top_builddir)lib >> +LDFLAGS += -B$(top_builddir)lib -Wl,-rpath,./ >> - -Wl,-rpath-link,$(top_builddir)lib >> UCLIBC_LDSO_ABSPATH=$(shell pwd) >> ifdef TEST_INSTALLED_UCLIBC >> - -LDFLAGS += -Wl,-rpath,./ >> - -UCLIBC_LDSO_ABSPATH=$(SHARED_LIB_LOADER_PREFIX) >> + UCLIBC_LDSO_ABSPATH=$(SHARED_LIB_LOADER_PREFIX) >> +else >> + LDFLAGS += -Wl,-rpath,$(top_builddir)lib >> + UCLIBC_LDSO_ABSPATH=$(shell pwd) >> endif >> >> ifeq ($(findstring -static,$(LDFLAGS)),) > _______________________________________________ > uClibc mailing list > [email protected] > http://lists.busybox.net/mailman/listinfo/uclibc > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmHcPUACgkQRwXTQ2P7MPWAVACeOqvbuwJ2A4hBUWU9G2Oet0I+ ouEAoJGUjeRegHeFZOgT6TyTCRhZzHIZ =xe/k -----END PGP SIGNATURE----- _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
