-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Salvatore CRO' wrote: > Hi Carmelo, > Attached is a proposal tailored for rpc test that could be very easily > extedend to all tests in uClibc. Indeed it avoids "include ../../.config" in > test Makefile by : > > - creating a new file Makefile.in with the same contents of existing > Makefile but "include ../Test.mak" > - replacing existing Makefile by a new one that only does some includes, > first one being "include ../Rules.mak" (that in turns got "include > ../../.config"), then includes the new Makefile.in and finally ../Test.mak > - removing "include ../Rules.mak" from ../Test.mak, since we've just done > it in Makefile. > > By including ../Rules.mak first, we ensure that _actual_ UCLIBC_HAS_xxx > values (through ../../.config) get evaluated by Makefile.in to arrange the > TESTS variable so that all due sources are correctly compiled. > > Using this approach, Makefile is the same for all tests and contains include > statements only while all test-specific settings lie in the new Makefile.in > > Cheers, > Salvo. > Hi Salvo, I like it ;-): it appear a cleaner/working design. If nobody has concerns, please go ahead and post a patch to fix makefile overall.
Thanks, Carmelo > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf > Of Carmelo AMOROSO > Sent: Wednesday, March 04, 2009 10:34 AM > To: Bernhard Reutner-Fischer > Cc: [email protected] > Subject: Re: svn commit: trunk/uClibc/test/crypt > > Bernhard Reutner-Fischer wrote: >> On Tue, Feb 24, 2009 at 01:07:15PM +0100, Carmelo AMOROSO wrote: > >>>> Log: >>>> - disable libcrypt tests if we have no libcrypt >>>> >>>> >>>> Modified: >>>> trunk/uClibc/test/crypt/Makefile >>>> >>>> >>>> Changeset: >>>> Modified: trunk/uClibc/test/crypt/Makefile >>>> =================================================================== >>>> --- trunk/uClibc/test/crypt/Makefile 2009-02-23 10:00:22 UTC (rev > 25421) >>>> +++ trunk/uClibc/test/crypt/Makefile 2009-02-23 10:50:49 UTC (rev > 25422) >>>> @@ -1,6 +1,12 @@ >>>> # uClibc crypt tests >>>> # Licensed under the LGPL v2.1, see the file COPYING.LIB in this > tarball. >>>> >>>> +include ../../.config >>>> + >>>> +ifneq ($(UCLIBC_HAS_CRYPT),y) >>>> +TESTS_DISABLED := $(patsubst %.c,%,$(wildcard *.c)) endif >>>> + >>>> include ../Test.mak >>>> >>>> EXTRA_LDFLAGS := -lcrypt >>>> >>> Hi Bernhard, >>> should not be better disabling the whole directory in the >>> test/Makefile ? >> Yes, that would be better. >>> Anyway it seems that you are confirming that we need to review all >>> the test Makefiles that are tryng to test some of the UCLIBC_HAS_xxx >>> for selectively build tests. >> Yes. I've touched only those few that cought my eye and cleaned up the >> math stuff so we test if we have the desired set of the API really >> exported (IIRC i have to push this to trunk too). Any help with the >> testsuite would be highly appreciated. > > > Bernhard, > we are looking in my team at this issue. Indeed we are discovering that > several tests are not actually built/executed due to this problem. > We'll come soon with a proposal for restructuring testsuite build system > (not a huge impact anyway) to solve definitely the issue. > I don't like polluting all the Makefile with "include ../../.config". > > Cheers, > Carmelo _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkmuo5sACgkQoRq/3BrK1s9yWQCgpH5rWoHhUF0YXt0sxiBqpkz0 niYAnRnwnRTMA16Q2mHOsl69TBwSl+nW =KUqV -----END PGP SIGNATURE----- _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
