On Fri, 10 Apr 2009 09:14 +0200, "Carmelo AMOROSO" <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Folks, > I've looked at the change history of ldso/ldso/mips/elfinterp.c and > I think that we have made a lot of mistakes with this file. > > rev | committer | change > - --------------------------------------------------------------- > 15882 | sjhill | added TLS relocations support, > | based on dl_find_hash2; I assume mips work > 22528 | kraj | use _dl_find_hash instead of _dl_find_hash2 > 22715 | carmelo | back to _dl_find_hash2 > 22725 | kraj | revert to _dl_find_hash again (with sym_tls as > | last argument > 24524 | vda | removed all TLS code > 25520 | carmelo | recovered to 22725 (khem change) > - --------------------------------------------------------------- > > At the end I think that the implementation is completely broken, > probably since first use of _dl_fnd_hash. > > I'd suggest two approach: > 1) go back to older _dl_find_hash2 implementation and see if it > works > 2) understand how to TLS relocs must be handled and use > _dl_find_hash accordingly > > I'd prefer solution 2), but this should be done by somebody with a > mips target for testing; I don't have. > > Hope it helps. > > Carmelo
Thanks, Carmelo. I will take a look. The flip-flopping between _dl_find_hash and dl_find_hash2 looks like a good candidate for debug/test. DanE -- http://www.fastmail.fm - Same, same, but different... _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
