On 1/12/2011 5:46 AM, Carmelo AMOROSO wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/12/2011 12:34 PM, Carmelo AMOROSO wrote:

Folks,
even if a bit late here the patch set for handling protected symbols for
all architecture in the common code _dl_find_hash.
The implementation is based on a Jocke's proposal modified according to a my
suggestion that will allow to cope with proetcted symbols, TLS, FDPIC
and prelinking as well.

Work build/runtime tested on SH4. The only architecture that has not been
changed is FRV that seems to be completely broken (it is using a 
_dl_find_hash_mod
function that it is not longer available).

I see rooms for further tidy-up of the ldso code after this change, but I-d 
prefer
to apply them later.

I'd kindly ask arch maintainers and uClibc fans to review and possibily test
their own preferred archs. We should be able to include this code for the 
0.9.32 asap.

Thanks and enjoy uClibc,
Carmelo

Carmelo Amoroso (4):
   Revert "ldso/i386: support protected symbols"
   Revert "ldso_sh: add support for protected symbols to SH"
   Revert "ldso/arm: Correct protected symbol resolution"
   ldso: get rid of _dl_lookup_hash

Salvatore Cro (1):
   Add protected symbols support for all architectures

  ldso/include/dl-hash.h        |   20 ++++++------------
  ldso/ldso/arm/elfinterp.c     |   17 ++++++---------
  ldso/ldso/avr32/elfinterp.c   |   13 ++++++-----
  ldso/ldso/bfin/elfinterp.c    |   18 +++++++++++-----
  ldso/ldso/cris/elfinterp.c    |    5 +++-
  ldso/ldso/dl-hash.c           |   22 ++++++++++++--------
  ldso/ldso/i386/elfinterp.c    |   16 ++++++--------
  ldso/ldso/m68k/elfinterp.c    |   15 +++++++------
  ldso/ldso/mips/elfinterp.c    |    6 ++++-
  ldso/ldso/powerpc/elfinterp.c |   20 ++++++++++--------
  ldso/ldso/sh/elfinterp.c      |   44 +++++++++++++++++++---------------------
  ldso/ldso/sh64/elfinterp.c    |    7 ++++-
  ldso/ldso/sparc/elfinterp.c   |   24 ++++++++++++----------
  ldso/ldso/x86_64/elfinterp.c  |   20 ++++++++++--------
  ldso/ldso/xtensa/elfinterp.c  |   11 +++++----
  ldso/libdl/libdl.c            |    7 +++--
  16 files changed, 141 insertions(+), 124 deletions(-)


Once this will be reviewed and approved, I'll manage to merge&test it on
prelink branch. This will allow us to easily merge prelink back to
master after 0.9.32 release at least.



I have seen no issues on x86, arm and mips( with patch 4/5 fixed myself for mips) systems booted fine and tests showed no regressions on ppc it built fine but I do not have runtime results due to other reasons.

Acked-by: Khem Raj <[email protected]>

Cheers,
Carmelo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0tsK0ACgkQoRq/3BrK1s/uXwCfb24klSPfTagqlBpY4k2fUpNd
pLIAn1A59ZRdGJKuyZbAoXrIXYFu6Y8r
=WB/D
-----END PGP SIGNATURE-----
_______________________________________________
uClibc mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/uclibc

_______________________________________________
uClibc mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/uclibc

Reply via email to