On Sat, Mar 26, 2011 at 9:49 AM, Peter Mazinger wrote: >> On Sat, Mar 19, 2011 at 2:51 PM, Khem Raj wrote: >> > The guard is changed to allow to be used the file in libc as well. >> > Include string.h (although already included by ldso.h). >> >> this doesnt make much sense. if you want to use it in libc as well, >> then check for libc. >> >> #if !defined(IS_IN_libdl) && !defined(IS_IN_libc) > > going my way I need only one check, anyway, the changes using this > are far away (somewhere in my patch queue at position >1500)
it doesnt matter the number of checks. what matters is the intention. if these things are intended to be used outside of libdl/libc, then that is what you should be checking for. if the intention for these to only be used in librt, then that is what you should be checking for. it seems to me that the intention is for the former behavior and thus you should be using the defines i quoted above. -mike _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
