Bernd Schmidt <[email protected]> wrote: On 04/05/2011 11:03 PM, Bernhard Reutner-Fischer wrote: > On Fri, Apr 01, 2011 at 03:06:55PM +0200, Bernd Schmidt wrote: > >> + char *piclib2map = 0; > > = NULL >> +#ifndef MIN >> +# define MIN(a,b) ((a) < (b) ? (a) : (b)) > > MIN is always defined via sys/param.h >> + cant_map: > > Please use uppercase labels (also for cant_map1 et al) >> +#if defined (__SUPPORT_LD_DEBUG__) >> + { >> + extern char *_dl_debug; >> + extern int _dl_debug_file; > > Why are these 2 externs needed? I suspect they aren't. However, everything you pointed out already existed in the code I was changing. Below is a new version, however I'd like to ask you to reconsider the uppercase labels, which isn't consistent with anything else in this file, or in fact most other code in uClibc as shown by find|xargs grep goto. Nor is it done like this in any popular coding style I'm aware of (e.g. Linux or GNU). Bernd
Hi, You are right, let's leave the labels lowercase. Please install (the other one too). Thanks, _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
