On 04/10/2011, at 12:30 AM, Mike Frysinger wrote:

> On Sunday, October 02, 2011 19:47:43 Steve Bennett wrote:
>> On 02/10/2011, at 4:57 AM, Mike Frysinger wrote:
>>> On Thursday, September 29, 2011 18:40:21 Steve Bennett wrote:
>>>> -#define __BYTE_ORDER __BIG_ENDIAN
>>>> +#ifdef _BIG_ENDIAN
>>>> +# define __BYTE_ORDER __BIG_ENDIAN
>>>> +#else
>>>> +# ifdef _LITTLE_ENDIAN
>>>> +#  define __BYTE_ORDER __LITTLE_ENDIAN
>>>> +# endif
>>>> +#endif
>>> 
>>> are you sure this is correct ?  who defines "_BIG_ENDIAN" ?
>> 
>> It's defined by the toolchain.
> 
> that's fairly unusual for the toolchain.  but i guess it's too late now to 
> fix 
> gcc to use better names.  please add a comment that _{BIG,LITTLE}_ENDIAN come 
> from the toolchain.

OK.

> 
>> c.f. libc/sysdeps/linux/mips/bits/endian.h
> 
> they aren't using _{BIG,LITTLE}_ENDIAN.  they're using sane name-spaced 
> defines which are a bit more obvious in that they're coming from gcc.
> -mike

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au      P: +61 434 921 300
E: [email protected]   F: +61 7 3391 6002





_______________________________________________
uClibc mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/uclibc

Reply via email to