* Carmelo AMOROSO wrote:
> On 27/10/2011 17.32, Mike Frysinger wrote:
> > On Thu, Oct 27, 2011 at 16:42, Carmelo AMOROSO wrote:
> >> +ifndef CROSS_COMPILE
> >> +CROSS_COMPILE=
> >>  endif
> > 
> > this is kind of useless logic.  i would change it to one line:
> > CROSS_COMPILE ?= $(CROSS)
> > -mike
> > 
> 
> I've really done a sed, so I've kept the original logic.
> IIUC you are suggesting to keep both CROSS and CROSS_COMPILE option,
> If so, it should be the opposite
> 
> CROSS ?= $(CROSS_COMPILE)
> 
> shouldn't it ?

I believe the point is that CROSS_COMPILE evaluates to the empty string
anyway when it isn't defined, that's why it is useless. I agree with Mike
that falling back to $(CROSS) makes sense as it will keep backwards
compatibility with the old behaviour.

Thierry

Attachment: pgp3YytBOC4RC.pgp
Description: PGP signature

_______________________________________________
uClibc mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/uclibc

Reply via email to