On Wednesday 31 October 2012 09:25:16 Natanael Copa wrote: > +ifeq ($(UCLIBC_SUSV4_LEGACY),y)
i don't think these are even SUSV4 legacy. they're part of SUSV3 and marked obsolete there and then removed from SUSV4. > +ASFLAGS-setcontext.S := -D_LIBC_REENTRANT > +ASFLAGS-getcontext.S := -D_LIBC_REENTRANT > +ASFLAGS-swapcontext.S := -D_LIBC_REENTRANT not specific to your change, but this doesn't seem right. we add it to like ASFLAGS with every .S file ? > +ifeq ($(UCLIBC_HAS_THREADS_NATIVE),y) > +#Needed to use the correct SYSCALL_ERROR_HANDLER > +ASFLAGS-setcontext.S += -DUSE___THREAD > +ASFLAGS-getcontext.S += -DUSE___THREAD > +ASFLAGS-swapcontext.S += -DUSE___THREAD > +endif this is specific to your change. i don't think this is correct. this define is setup by tls.h and shouldn't be manually added to specific files. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
