On Thu, Aug 28, 2014 at 12:31:22PM +0200, Waldemar Brodkorb wrote: > tst-spin1.c compile breaks with: > test/nptl/tst-spin1.c:34: undefined reference to `pthread_spin_lock' > > pthread_spin_lock and pthread_spin_trylock is missing while > building sparc. add the meta c files here.
1) what about pthread_spin_unlock? 2) wouldn't it be nicer to teach libpthread/nptl/sysdeps/sparc/Makefile.arch which of sparc32/sparc64 it should use? 3) As you have seen (and removed the typoed subdirs), there is a specialization for sparcv9 there which should probably be used. Applied the below in the meantime, thanks! > > Signed-off-by: Waldemar Brodkorb <[email protected]> > --- > libpthread/nptl/sysdeps/sparc/pthread_spin_lock.c | 5 +++++ > libpthread/nptl/sysdeps/sparc/pthread_spin_trylock.c | 5 +++++ > 2 files changed, 10 insertions(+) > create mode 100644 libpthread/nptl/sysdeps/sparc/pthread_spin_lock.c > create mode 100644 libpthread/nptl/sysdeps/sparc/pthread_spin_trylock.c > > diff --git a/libpthread/nptl/sysdeps/sparc/pthread_spin_lock.c > b/libpthread/nptl/sysdeps/sparc/pthread_spin_lock.c > new file mode 100644 > index 0000000..dcc5ae2 > --- /dev/null > +++ b/libpthread/nptl/sysdeps/sparc/pthread_spin_lock.c > @@ -0,0 +1,5 @@ > +#if defined(__arch64__) > +#include "sparc64/pthread_spin_lock.c" > +#else > +#include "sparc32/pthread_spin_lock.c" > +#endif > diff --git a/libpthread/nptl/sysdeps/sparc/pthread_spin_trylock.c > b/libpthread/nptl/sysdeps/sparc/pthread_spin_trylock.c > new file mode 100644 > index 0000000..af63eec > --- /dev/null > +++ b/libpthread/nptl/sysdeps/sparc/pthread_spin_trylock.c > @@ -0,0 +1,5 @@ > +#if defined(__arch64__) > +#include "sparc64/pthread_spin_trylock.c" > +#else > +#include "sparc32/pthread_spin_trylock.c" > +#endif > -- > 1.8.5.2 (Apple Git-48) > > _______________________________________________ > uClibc mailing list > [email protected] > http://lists.busybox.net/mailman/listinfo/uclibc _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
