Hi Max,

Massimo Oss Noser wrote:
I patched uClinux-dist-20070130 with
uClinux-dist-20070130-20070621.patch. I encountered some problems
compiling qspi driver.

In "drivers/spi/spi_coldfire.c":
...
static int init_queue(struct driver_data *drv_data)
{
        INIT_LIST_HEAD(&drv_data->queue);
        spin_lock_init(&drv_data->lock);

        drv_data->run = QUEUE_STOPPED;
        drv_data->busy = 0;

        tasklet_init(&drv_data->pump_transfers,
                        pump_transfers, (unsigned long)drv_data);

  INIT_WORK(&drv_data->pump_messages, pump_messages, drv_data);  <<
        drv_data->workqueue = create_singlethread_workqueue(
                                        drv_data->master->cdev.dev->bus_id);
        if (drv_data->workqueue == NULL)
                return -EBUSY;

        return 0;
}
...

  CC      drivers/spi/spi_coldfire.o
drivers/spi/spi_coldfire.c:649:61: error: macro "INIT_WORK" passed 3
arguments, but takes just 2

Should this work?

    INIT_WORK(&drv_data->pump_messages, pump_messages);

Just changing the macro is not enough, almost certainly
pump_messages() function will need to change too.

Look for example changes in other drivers that use INIT_WORK.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     [EMAIL PROTECTED]
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to