* Greg Ungerer | 2008-04-28 16:15:13 [+1000]:
>Hi Sebastian,
Hi Greg,
>>+#ifdef CONFIG_FRAME_POINTER
>>+ printk(KERN_EMERG "Call Trace:\n");
>>+#else
>>+ printk(KERN_EMERG "The following call trace is a joke. "
>>+ "Enable CONFIG_FRAME_POINTER in Kernel Kconfig for usefull "
>>+ "output.\n");
>>+#endif
>>+
>>+ last_stack = stack - 1;
>>+ while (stack <= endstack && stack > last_stack) {
>>+
>>+ addr = *(stack +1);
>>+ printk(KERN_EMERG " [%08lx] ", addr);
>>+ print_symbol(KERN_CONT "%s\n", addr);
>>+
>>+ last_stack = stack;
>>+ stack = (unsigned long *)*stack;
>> }
>> printk("\n");
>> }
>
>I don't like this specific chunk. Seems pointless even trying to
>do a symbolic call trace if CONFIG_FRAME_POINTER is disabled.
>So I would rather do:
>
>> #ifdef CONFIG_FRAME_POINTER
>> printk(KERN_EMERG "Call Trace:\n");
>>
>> last_stack = stack - 1;
>> while (stack <= endstack && stack > last_stack) {
>>
>> addr = *(stack +1);
>> printk(KERN_EMERG " [%08lx] ", addr);
>> print_symbol(KERN_CONT "%s\n", addr);
>>
>> last_stack = stack;
>> stack = (unsigned long *)*stack;
>154a144,146
>> #else
>> printk(KERN_EMERG "CONFIG_FRAME_POINTER disabled, no symbolic
>call trace\n");
>> #endif
>
>
>Otherwise I am happy with it.
Okey, will do.
I dump later today my .25 queue with a total of 36 patches if this is
okey with you? It contains a refresh of my earlier patches and hopefully
a clean fec.c :)
>Greg
Sebastian
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
