Hi Jate,
Jate Sujjavanich wrote:
While debugging the dreaded "bad frame format", I realized that the bus
error handler for m68knommu/Coldfire could be improved.
This patch adds more verbose output for a bus error on Coldfire.
Signed-off-by: Jate Sujjavanich <[EMAIL PROTECTED]>
The 2.4 code looks ok, so I applied that.
(I can't seem to connect to cvs.uclinux.org at the moment so I
can't update the uClinux-2.4.x CVS. Will do as soon as I can get
to it).
I have not had a chance to test it, but I believe that the attached
similar patch could also be made to arch/m68knommu/kernel/traps.c for
the 2.6.x series kernel. Do you think the CONFIG_COLDFIRE's are even
needed?
Not sure. I don't recall if the older m68k non-MMU parts support
that format value or not. (Can anyone else verify that? I'll have
to go look that up otherwise).
Otherwise just some formating nits. For 2.6.x kernels it is
recommended to run scripts/checkpatch.pl on any patches you
generate. Feel free to regenerate the patch, or I can quickly
fix the formating before applying?
I noticed that in the 2.4 traps.c, there were a lot of ifdef's of code
for 680x0 processors. I have a feeling that these left over from m68k
during the original port. Could these be removed?
Yep, they sure could.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: [EMAIL PROTECTED]
Secure Computing Corporation PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
