Hi,

currently there are three drivers for the Coldfire QSPI interface in the test-release. All of them are broken in varying degrees, so I am working to get at least one running smoothly. Mike Lavenders latest Driver (spi_coldfire.c), which was also annouced in this list, seems to be the best candidate for the job.

Today I managed to get it building, while not being able to test it on real hardware because of time constraints. The Problems I found and hope to have fixed are: - Adapting it to the completely revamped workqueue API, I took some HiSax driver and a LWN article as a reference - The SA_INTERRUPT flag for request_irq seems to be gone, not being able to find any reference what to pass here, I used 0 (zero) as an interim value.

My questions are:
- What are suitable values for flags passed to request_irq, this whole function seems to be platform dependant but I can't find any implementation in arch/m68knommu - There is a reason for irq not being initialized in coldfire_spi_probe() ? Look for a line like
=========================
out_error_irq_alloc:
        free_irq(irq, drv_data);
=========================
the compiler and me cannot see any initialization of irq in the whole function. Maybe a bug, or just a dummy-variable?

Greg: Would you agree to remove the older, even more broken mcf_qspi.c driver? (The other broken one is in character-devices menu somewhere, I'm currently not on my delvelopment machine)

Greetings
  Peter

_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to