There are a bunch of things wrong with the oggplay makefile for oggplay and oggenc ... some highlights: - CPPFLAGS isnt respected - -Werror breaks building with gcc-4.3 (maybe real bug, but failures on warnings shouldnt make it into a release) - parallel build failure due to incorrect dependency list
Signed-off-by: Mike Frysinger <[email protected]> --- user/oggplay/Makefile | 19 ++++++------------- 1 files changed, 6 insertions(+), 13 deletions(-) diff --git a/user/oggplay/Makefile b/user/oggplay/Makefile index c6a8d00..05efa61 100644 --- a/user/oggplay/Makefile +++ b/user/oggplay/Makefile @@ -3,30 +3,23 @@ DIRS = Tremor EXEC = oggplay -OBJS = oggplay.o -XLIB = Tremor/libvorbisidec.a +OBJS = oggplay.o Tremor/libvorbisidec.a EXEC2 = oggenc OBJS2 = oggenc.o .PHONY: clean romfs all $(DIRS) +CFLAGS += -Wall +CPPFLAGS += -I$(DIRS) + all: $(DIRS) $(EXEC) $(EXEC2) $(EXEC): $(OBJS) - $(CC) $(LDFLAGS) -o $@ $^ $(XLIB) $(LDLIBS$(LDLIBS_$@)) - -oggplay.o: oggplay.c - $(CC) $(CFLAGS) -c $< -o $@ -I$(DIRS) -Wall -Werror - $(EXEC2): $(OBJS2) - $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS$(LDLIBS_$@)) - -oggenc.o: oggenc.c - $(CC) $(CFLAGS) -c $< -o $@ -I$(DIRS) -Wall -Werror -$(DIRS): - make -C $@ +Tremor/libvorbisidec.a: + $(MAKE) -C Tremor romfs: $(ROMFSINST) /bin/$(EXEC) -- 1.6.2 _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
