On Fri, Aug 14, 2009 at 09:34:15AM +0200, Ithamar R. Adema wrote:
> Daniel Glöckner wrote:
> >     if (size > (vma->vm_end - from) >> PAGE_SHIFT)
> >             return -EINVAL;

I should have read the mmu version first.
This must be

        if (size > vma->vm_end - from)
                return -EINVAL;

as size is in bytes, not pages.

> This looks good, though dma_mmap() in arch/arm/mm/consistent-nommu.c 
> passes wrong parameters and fail :( I'll take a closer look at this 
> during the weekend...

dma_mmap looks good. If it doesn't work after the above change, the
caller of dma_mmap may need to implement get_unmapped_area to set
vma->vm_start.

  Daniel
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to