Jie Zhang <jie.zh...@analog.com> wrote:

> > There needs to be a mapping covering the SRAM region for the purposes of the
> 
> Our GDB is still lack of the feature to debug applications using SRAM. So this
> part of code was not got exercised. So if we remove this line, can this patch
> got merged?

No.  Firstly, the piece of storage that gets munmapped isn't used, so unmapping
it isn't wrong.  What you need to do is to put a mapping over the bit of the
SRAM you wish to use and then fill it and use it.  Ideally, you'd do this
inside of do_mmap_pgoff() - that way those bits of the SRAM can be shared, but
I'm not sure how best to do that.

But you need to stick a VMA over it so that various checks don't spit
EFAULT/EIO at you.

David
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to