On Thursday 31 December 2009 20:26:45 Jun Sun wrote:

when posting updates, you should put the "v2" and such inside of the "[patch]" 
marker like so: [PATCH v2].  git will remove this automatically when applying.

>  #define      flat_old_ram_flag(flags)        (flags)
> -#define      flat_reloc_valid(reloc, size)   ((reloc) <= (size))
> +#define      flat_reloc_valid(reloc, size)   ((reloc) <= (size) + 0x1000)
> +/* [jsun] new gcc 4.x generates ANCHOR symbols in order to reduce the size

comments go above the thing they're documenting, not below.  the "[jsun]" is 
also not really useful -- no one who reads this after the fact will have any 
idea what "[jsun]" means.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to