On Tue, May 25, 2010 at 21:24, Mike Frysinger <vap...@gentoo.org> wrote:
> From: Jie Zhang <jie.zh...@analog.com>
>
> The recent commit 1f0ce8b3dd667dca7 which moved the ARCH_SLAB_MINALIGN
> default into the global header inadvertently broke FLAT for a bunch of
> systems. Blackfin systems now fail on any FLAT exec with:
> Unable to read code+data+bss, errno 14
> When your /init is a FLAT binary, obviously this can be annoying ;).
>
> This stems from the alignment usage in the FLAT loader. The behavior
> before was that FLAT would default to ARCH_SLAB_MINALIGN only if it was
> defined, and this was only defined by arches when they wanted a larger
> alignment value. Otherwise it'd default to pointer alignment. Arguably,
^^^^^^^^^^^^^^^^^
That would be __alignof__(void *)
> +#elif defined(ARCH_SLAB_MINALIGN)
> #define FLAT_DATA_ALIGN (ARCH_SLAB_MINALIGN)
> #else
> #define FLAT_DATA_ALIGN (sizeof(void *))
Not sizeof(void *)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
