Resubmission:




The arch/m68k/include/asm/ide.h produces errors when the IDE driver is compiled 
for my 523x uClinux system under kernel. The header makes some redefines of 
operators not defined in the arch/m68k/include/asm/io_no.h header. There are no 
separate mmio and iospace defines.

Signed-off-by: Jate Sujjavanich <jsujjavan...@syntech-fuelmaster.com>

diff --git a/arch/m68k/include/asm/ide.h b/arch/m68k/include/asm/ide.h
index 3958726..492fee8 100644
--- a/arch/m68k/include/asm/ide.h
+++ b/arch/m68k/include/asm/ide.h
@@ -1,6 +1,4 @@
 /*
- *  linux/include/asm-m68k/ide.h
- *
  *  Copyright (C) 1994-1996  Linus Torvalds & authors
  */
 
@@ -34,6 +32,8 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 
+#ifdef CONFIG_MMU
+
 /*
  * Get rid of defs from io.h - ide has its private and conflicting versions
  * Since so far no single m68k platform uses ISA/PCI I/O space for IDE, we
@@ -53,5 +53,14 @@
 #define __ide_mm_outsw(port, addr, n)  raw_outsw((u16 *)port, addr, n)
 #define __ide_mm_outsl(port, addr, n)  raw_outsl((u32 *)port, addr, n)
 
+#else
+
+#define __ide_mm_insw(port, addr, n)   io_insw((unsigned int)port, addr, n)
+#define __ide_mm_insl(port, addr, n)   io_insl((unsigned int)port, addr, n)
+#define __ide_mm_outsw(port, addr, n)  io_outsw((unsigned int)port, addr, n)
+#define __ide_mm_outsl(port, addr, n)  io_outsl((unsigned int)port, addr, n)
+
+#endif /* CONFIG_MMU */
+
 #endif /* __KERNEL__ */
 #endif /* _M68K_IDE_H */





-----Original Message-----
From: uclinux-dev-boun...@uclinux.org [mailto:uclinux-dev-boun...@uclinux.org] 
On Behalf Of Sam Ravnborg
Sent: Friday, June 11, 2010 12:10 PM
To: uClinux development list
Subject: Re: [uClinux-dev] [PATCH] arch/m68k/ide.h fix for nommu

On Fri, Jun 11, 2010 at 10:05:27AM -0400, Jate Sujjavanich wrote:
> 
> 
> -----Original Message-----
> From: uclinux-dev-boun...@uclinux.org 
> [mailto:uclinux-dev-boun...@uclinux.org] On Behalf Of Sam Ravnborg
> Sent: Monday, June 07, 2010 12:09 PM
> To: uClinux development list
> Subject: Re: [uClinux-dev] [PATCH] arch/m68k/ide.h fix for nommu
> 
>>> - *  linux/include/asm-m68k/ide.h
>>> + *  arch/m68k/include/ide.h
>> Would be nice if you could remove this redundant filename.
> Sure. Should the copyright comments remain?

Yes - please keep these (if they are relevant for the code in question).
If you are in daught keep them.

        Sam
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

 
 
************************************************************************************
This footnote confirms that this email message has been scanned by
PineApp Mail-SeCure for the presence of malicious code, vandals & computer 
viruses.
************************************************************************************



_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to