On Fri, Aug 27, 2010 at 04:22:13PM +1000, Greg Ungerer wrote: > > Hi Philippe, > > Philippe De Muyter wrote: >> The Coldfire MCF547x/MCF548x have the same interrupt controller than >> the MCF528x, e.g., but only one, not two as in the MCF528x. Modify >> intc-2.c to support only one interrupt controller if MCFICM_INTC1 is >> not defined. >> Signed-off-by: Philippe De Muyter <p...@macqel.be> >> --- >> arch/m68knommu/platform/coldfire/intc-2.c | 30 >> +++++++++++++++++++++++----- >> 1 files changed, 24 insertions(+), 6 deletions(-) >> diff --git a/arch/m68knommu/platform/coldfire/intc-2.c >> b/arch/m68knommu/platform/coldfire/intc-2.c >> index a0c72ec..060ff7b 100644 >> --- a/arch/m68knommu/platform/coldfire/intc-2.c >> +++ b/arch/m68knommu/platform/coldfire/intc-2.c >> @@ -1,9 +1,11 @@ >> /* >> * intc-2.c >> * >> - * General interrupt controller code for the many ColdFire version 2 >> cores >> - * that use the two region INTC interrupt controller. This includes the >> - * 523x family, 5270, 5271, 5274, 5275, and the 528x families. >> + * General interrupt controller code for the many ColdFire cores that use >> + * interrupt controllers with 63 interrupt sources, organized as 56 >> fully- >> + * programmable + 7 fixed-level interrupt sources. This includes the 523x >> + * family, the 5270, 5271, 5274, 5275, and the 528x family which have two >> such >> + * controllers, and the 547x and 548x families which have only one of >> them. >> * >> * (C) Copyright 2009, Greg Ungerer <g...@snapgear.com> >> * >> @@ -27,17 +29,27 @@ >> * We don't really care so much what they are, we don't rely on the >> * tranditional priority interrupt scheme of the m68k/ColdFire. >> */ >> -static u8 intc_intpri = 0x36; >> +static u8 intc_intpri = 066; > ^^^ > Why change this to octal?
Because it reflects the organisation of the ICRn registers : 2 bits unused 3 bits for level 3 bits for priority in level Do you want me to add a comment ? Philippe -- Philippe De Muyter phdm at macqel dot be Tel +32 27029044 Macq Electronique SA rue de l'Aeronef 2 B-1140 Bruxelles Fax +32 27029077 _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
