On Fri, Jun 24, 2011 at 07:45, <g...@snapgear.com> wrote:
> From: Greg Ungerer <g...@uclinux.org>
>
> The following patch merges the mmu and non-mmu versions of the m68k
> bitops.h files. Now there is a good deal of difference between the two
> files, but none of it is actually an mmu specific difference. It is
> all about the specific m68k/coldfire varient we are targeting. So it
> makes an awful lot of sense to merge these into a single bitops.h.
>
> There is a number of ways I can see to factor this code. The approach
> I have taken here is to keep the various versions of each macro/function
> type together. This means that there is some ifdefery with each to handle
> each CPU type. I have introduced a new config option so that processors
> that support the more advanced bit field instructions can select that.
> It keeps the ifdefs a little cleaner at least.
>
> I have added some comments in a couple of appropriate places to try
> and make it clear what the differences we are dealing with are.
> Specifically the instruction and addressing mode differences we have
> to deal with.
>
> The merged form keeps the same underlying optimizations for each CPU
> type for all the general bit clear/set/change and find bit operations.
> It does switch to using the generic le operations though, instead of
> any local varients.
>
> Build tested on ColdFire, 68328, 68360 (which is cpu32) and 68020+.
> Run tested on ColdFire and ARAnyM.
>
> Signed-off-by: Greg Ungerer <g...@uclinux.org>
Thanks!
If you fix the indentation and spacing problems reported by checkpatch, you
can add my
Acked-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
