Hi Greg,

thank you for the hint with scripts/checkpatch.pl, it helped a lot.

On Aug 8, 2011, at 7:03 AM, Greg Ungerer wrote:
> Overall it looks right. Just a couple of minor nits to clean up:

> Lets simplify the logic here a little and do:
Done.
> 
> There is no spi-mcf520x.c in this patch...
> Is there supposed to be?
This is a platform definition file for my hardware. This will be be released 
along with the hardware. Just forget about it..
> 
> Can you regenerate your patch, and add a Signed-off-by?
Please find attached the regenerated patch. 
> 
> Regards
> Greg

Regards,
 Peter

Attachment: linux-3.0.0+-5208_spi.patch
Description: Binary data

_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to