Hi, That's right. There are misplaced spaces in the defines.
I tried to find where this typos were introduced, but going back to the old uClinux CSV achieve, in January 2001 these typos were already there: http://cvs.uclinux.org/cgi-bin/cvsweb.cgi/uClinux-2.4.x/include/asm-m68knommu/MC68328.h (check rev 1.1) But in kernel 2.0.x this was correct. I guess nobody ever used the SPI module ever... (and now, probably won't be used until the end of days). Regards, Luis On Thu, Feb 21, 2013 at 12:08 AM, Larry Baker <ba...@usgs.gov> wrote: > Steve, > > I see several typos being fixed: "SPIM _IRQ_NUM" -> "SPIM_IRQ_NUM", i.e., > there is a misplaced space in the defined constant identifier. > > Larry Baker > US Geological Survey > 650-329-5608 > ba...@usgs.gov > > > > On 20 Feb 2013, at 4:02 PM, Steve deRosier wrote: > > Hey Luis, > > Maybe I'm confused, but in addition to the real changes, I'm seeing > quite a few things that I think are white space changes: > > */ > > -#define IMR_MSPIM (1 << SPIM _IRQ_NUM) /* Mask SPI Master interrupt > */ > > +#define IMR_MSPIM (1 << SPIM_IRQ_NUM) /* Mask SPI Master interrupt > */ > > #define IMR_MTMR2 (1 << TMR2_IRQ_NUM) /* Mask Timer 2 > interrupt */ > > > I'm guessing that people will ask you to filter those out of your > functional commit before allowing the patches. > > - Steve > _______________________________________________ > uClinux-dev mailing list > uClinux-dev@uclinux.org > http://mailman.uclinux.org/mailman/listinfo/uclinux-dev > This message was resent by uclinux-dev@uclinux.org > To unsubscribe see: > http://mailman.uclinux.org/mailman/options/uclinux-dev > > > > _______________________________________________ > uClinux-dev mailing list > uClinux-dev@uclinux.org > http://mailman.uclinux.org/mailman/listinfo/uclinux-dev > This message was resent by uclinux-dev@uclinux.org > To unsubscribe see: > http://mailman.uclinux.org/mailman/options/uclinux-dev _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
